Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: find backup should also wait until backup volume is synced #1729

Merged
merged 3 commits into from
Feb 26, 2024

Conversation

yangchiu
Copy link
Member

@yangchiu yangchiu commented Feb 19, 2024

Which issue(s) this PR fixes:

Issue longhorn/longhorn#7543 longhorn/longhorn#7959

What this PR does / why we need it:

Sync the modification in #1668 to other find_backup_volume function occurrences in the test code.

Special notes for your reviewer:

Additional documentation or context

@yangchiu yangchiu requested review from innobead, ChanYiLin and a team February 19, 2024 02:04
@yangchiu yangchiu self-assigned this Feb 19, 2024
@yangchiu
Copy link
Member Author

@ChanYiLin Could you help to review this? Thank you!

Copy link
Member

@innobead innobead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@innobead innobead merged commit 66540f6 into longhorn:master Feb 26, 2024
5 checks passed
@innobead
Copy link
Member

@yangchiu see if need to backport.

@yangchiu
Copy link
Member Author

@mergify backport v1.6.x v1.5.x

Copy link

mergify bot commented Feb 27, 2024

backport v1.6.x v1.5.x

✅ Backports have been created

@yangchiu
Copy link
Member Author

@mergify backport v1.4.x

Copy link

mergify bot commented Feb 27, 2024

backport v1.4.x

✅ Backports have been created

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants