refactor(negative): rename check_data to reflect function purpose

Signed-off-by: Chin-Ya Huang <[email protected]>
longhorn · Nov 1, 2023 · 8a27c2d · 8a27c2d
1 parent 3d21dda
commit 8a27c2d
Show file tree

Hide file tree

Showing 6 changed files with 9 additions and 9 deletions.
diff --git a/e2e/keywords/volume.resource b/e2e/keywords/volume.resource
@@ -48,7 +48,7 @@ Wait until replica ${replica_0} rebuilt, delete replica ${replica_2}
     delete_replica    ${volume_name}    ${replica_2}
 
 Check data is intact
-    check_data    ${volume_name}    ${volume_data_checksum}
+    check_data_checksum    ${volume_name}    ${volume_data_checksum}
 
 Check volume ${idx} works
     ${volume_data_checksum} =     write_volume_random_data   ${volume_list}[${idx}]    1024

diff --git a/e2e/libs/keywords/volume_keywords.py b/e2e/libs/keywords/volume_keywords.py
@@ -49,9 +49,9 @@ def keep_writing_data(self, volume_name):
         self.volume.keep_writing_data(volume_name)
 
 
-    def check_data(self, volume_name, checksum):
+    def check_data_checksum(self, volume_name, checksum):
         logging(f"Checking volume {volume_name} data with checksum {checksum}")
-        self.volume.check_data(volume_name, checksum)
+        self.volume.check_data_checksum(volume_name, checksum)
 
 
     def delete_replica(self, volume_name, replica_node):

diff --git a/e2e/libs/volume/base.py b/e2e/libs/volume/base.py
@@ -43,7 +43,7 @@ def wait_for_replica_rebuilding_complete(self, volume_name, node_name):
         return NotImplemented
 
     @abstractmethod
-    def check_data(self, volume_name, checksum):
+    def check_data_checksum(self, volume_name, checksum):
         return NotImplemented
 
     @abstractmethod

diff --git a/e2e/libs/volume/crd.py b/e2e/libs/volume/crd.py
@@ -212,7 +212,7 @@ def wait_for_replica_rebuilding_complete(self, volume_name, node_name):
             node_name
         )
 
-    def check_data(self, volume_name, checksum):
+    def check_data_checksum(self, volume_name, checksum):
         node_name = self.get(volume_name)["spec"]["nodeID"]
         endpoint = self.get_endpoint(volume_name)
         _checksum = self.node_exec.issue_cmd(

diff --git a/e2e/libs/volume/rest.py b/e2e/libs/volume/rest.py
@@ -125,7 +125,7 @@ def wait_for_replica_rebuilding_complete(self, volume_name, node_name):
             time.sleep(RETRY_INTERVAL)
         assert completed
 
-    def check_data(self, volume_name, checksum):
+    def check_data_checksum(self, volume_name, checksum):
         return NotImplemented
 
     def cleanup(self, volume_names):

diff --git a/e2e/libs/volume/volume.py b/e2e/libs/volume/volume.py
@@ -65,8 +65,8 @@ def wait_for_replica_rebuilding_complete(self, volume_name, node_name):
             node_name
         )
 
-    def check_data(self, volume_name, checksum):
-        return self.volume.check_data(volume_name, checksum)
+    def check_data_checksum(self, volume_name, checksum):
+        return self.volume.check_data_checksum(volume_name, checksum)
 
     def cleanup(self, volume_names):
-        return self.volume.cleanup(volume_names)
+        return self.volume.cleanup(volume_names)