Skip to content

Commit

Permalink
Fix Longhorn managed components restart at the begining of a test
Browse files Browse the repository at this point in the history
The test CI deploys Longhorn with the setting value longhorn-critical
for the setting priority-class. Don't reset it to empty (which is
the default value defined in longhorn-manager code) because this will
restart Longhorn managed components and fail the test cases.

longhorn-7413

Signed-off-by: Phan Le <[email protected]>
  • Loading branch information
PhanLe1010 authored and innobead committed Jan 9, 2024
1 parent 93e1a11 commit 8460141
Showing 1 changed file with 7 additions and 0 deletions.
7 changes: 7 additions & 0 deletions manager/integration/tests/common.py
Original file line number Diff line number Diff line change
Expand Up @@ -3479,6 +3479,13 @@ def reset_settings(client):
# resetting this to an empty default value.
if setting_name == "storage-network":
continue
# The test CI deploys Longhorn with the setting value longhorn-critical
# for the setting priority-class. Don't reset it to empty (which is
# the default value defined in longhorn-manager code) because this will
# restart Longhorn managed components and fail the test cases.
# https://github.com/longhorn/longhorn/issues/7413#issuecomment-1881707958
if setting.name == SETTING_PRIORITY_CLASS:
continue

# The version of the support bundle kit will be specified by a command
# option when starting the manager. And setting requires a value.
Expand Down

0 comments on commit 8460141

Please sign in to comment.