test: fix flaky test case test_volume_reattach_after_engine_sigkill

the pod we're waiting could be terminated and recreated, so reading the pod could raise not found exception. wrapping it in try/except to make the waiting can continue. Signed-off-by: Yang Chiu <[email protected]>
longhorn · Jan 3, 2024 · 2832bb3 · 2832bb3
1 parent 6ece0d7
commit 2832bb3
Showing 1 changed file with 8 additions and 5 deletions.
diff --git a/manager/integration/tests/common.py b/manager/integration/tests/common.py
@@ -5000,11 +5000,14 @@ def wait_for_pod_restart(core_api, pod_name, namespace="default"):
 def wait_for_pod_phase(core_api, pod_name, pod_phase, namespace="default"):
     is_phase = False
     for _ in range(RETRY_COUNTS):
-        pod = core_api.read_namespaced_pod(name=pod_name,
-                                           namespace=namespace)
-        if pod.status.phase == pod_phase:
-            is_phase = True
-            break
+        try:
+            pod = core_api.read_namespaced_pod(name=pod_name,
+                                               namespace=namespace)
+            if pod.status.phase == pod_phase:
+                is_phase = True
+                break
+        except Exception as e:
+            print(f"Waiting for pod {pod_name} {pod_phase} failed: {e}")
 
         time.sleep(RETRY_INTERVAL_LONG)
     assert is_phase