feat: decrease transport_ack_timeout #251

derekbit · 2024-12-01T12:04:30Z

Which issue(s) this PR fixes:

Issue longhorn/longhorn#9874

Signed-off-by: Derek Su [email protected]

What this PR does / why we need it:

Special notes for your reviewer:

Additional documentation or context

coderabbitai · 2024-12-01T12:04:37Z

Walkthrough

The changes in this pull request involve modifying two constants related to timeout settings in the SPDK package. Specifically, the diskTransportAckTimeout in pkg/spdk/disk/nvme/nvme.go and the replicaTransportAckTimeout in pkg/spdk/types.go have both been updated from 14 seconds to 10 seconds. These adjustments are intended to affect the timeout behavior for disk transport acknowledgments and replica management, respectively. No other significant changes to logic or functionality are present in the affected files.

Changes

File Path	Change Summary
pkg/spdk/disk/nvme/nvme.go	Updated constant `diskTransportAckTimeout` from 14 to 10.
pkg/spdk/types.go	Updated constant `replicaTransportAckTimeout` from 14 to 10.

Assessment against linked issues

Objective	Addressed	Explanation
Ensure v2 volume does not enter ERROR state after deleting a replica (#9874)	❌	The changes do not address the race condition described in the issue.

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between e9de501 and 2559c18.

⛔ Files ignored due to path filters (4)

go.mod is excluded by !go.mod
go.sum is excluded by !**/*.sum, !go.sum
vendor/github.com/longhorn/go-spdk-helper/pkg/types/types.go is excluded by !vendor/**
vendor/modules.txt is excluded by !vendor/**

📒 Files selected for processing (2)

pkg/spdk/disk/nvme/nvme.go (1 hunks)
pkg/spdk/types.go (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (2)

pkg/spdk/types.go
pkg/spdk/disk/nvme/nvme.go

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)

pkg/spdk/types.go (1)

52-52: LGTM! Timeout reduction aligns with documented strategy

The reduction of replicaTransportAckTimeout from 14s to 10s aligns perfectly with the documented timing strategy in the comments:

NVMe-oF initiator ctrl-loss-tmo: 30s

Replica controller loss timeout: 15s

Fast I/O fail timeout: 10s

Transport ACK timeout: 10s (new value)

This creates a clear timing hierarchy that should help prevent the race condition where the initiator incorrectly determines target failure.

The timing hierarchy ensures:

Transport issues are detected within 10s

I/O failures are triggered within 10s

Base bdev removal occurs after 15s

Controller loss is determined at 30s

This layered approach should provide better failure detection and recovery.

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between bfa1d21 and b2fb481.

⛔ Files ignored due to path filters (4)

go.mod is excluded by !go.mod
go.sum is excluded by !**/*.sum, !go.sum
vendor/github.com/longhorn/go-spdk-helper/pkg/types/types.go is excluded by !vendor/**
vendor/modules.txt is excluded by !vendor/**

📒 Files selected for processing (2)

pkg/spdk/disk/nvme/nvme.go (1 hunks)
pkg/spdk/types.go (1 hunks)

🔇 Additional comments (1)

pkg/spdk/disk/nvme/nvme.go (1)

23-23: LGTM! Verify timeout hierarchy alignment

The reduction of diskTransportAckTimeout from 14s to 10s aligns well with the timeout hierarchy:

diskCtrlrLossTimeoutSec: 30s (main timeout)
diskFastIOFailTimeoutSec: 15s (half of controller loss)
diskTransportAckTimeout: 10s (new value)

This change should help fail faster in case of connection issues, potentially preventing the race condition described in issue #9874.

Let's verify if this timeout is used consistently across the codebase:

codecov · 2024-12-01T12:10:42Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 8.38%. Comparing base (46dd200) to head (2559c18).
Report is 2 commits behind head on main.

Additional details and impacted files

@@          Coverage Diff          @@
##            main    #251   +/-   ##
=====================================
  Coverage   8.38%   8.38%           
=====================================
  Files         21      21           
  Lines       7159    7159           
=====================================
  Hits         600     600           
  Misses      6478    6478           
  Partials      81      81

Flag	Coverage Δ
unittests	`8.38% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

derekbit · 2024-12-02T13:23:33Z

@DamiaSan This is ready for review. Thank you.

DamiaSan · 2024-12-02T14:52:54Z

Just one question: shouldn't we modify also the constants defined in go-spdk-helper\pkg\nvme\nvmecli.go?

derekbit · 2024-12-02T15:50:36Z

Just one question: shouldn't we modify also the constants defined in go-spdk-helper\pkg\nvme\nvmecli.go?

Which const?

DamiaSan · 2024-12-02T16:52:46Z

Just one question: shouldn't we modify also the constants defined in go-spdk-helper\pkg\nvme\nvmecli.go?

Which const?

	defaultCtrlLossTmo    = 30
	defaultKeepAliveTmo   = 5
	defaultReconnectDelay = 2

These are used by the nvme cli initiator, shouldn't it be affected by the same issue?

derekbit · 2024-12-02T23:51:07Z

These are used by the nvme cli initiator, shouldn't it be affected by the same issue?

No, the change of transport_ack_timeout is for the SPDK's transport layer and is nothing to do with the three parameters you mentioned.

Longhorn 9874 Signed-off-by: Derek Su <[email protected]>

Decreasing transport_ack_timeout value for imporving the error detection of the transport layer. Longhorn 9874 Signed-off-by: Derek Su <[email protected]>

derekbit requested review from innobead, c3y1huang, shuo-wu and DamiaSan December 1, 2024 12:04

coderabbitai bot reviewed Dec 1, 2024

View reviewed changes

derekbit force-pushed the issue-9874 branch from b2fb481 to e9de501 Compare December 2, 2024 13:23

derekbit self-assigned this Dec 2, 2024

derekbit mentioned this pull request Dec 2, 2024

[BUG] v2 volume may enter ERROR state after deleting an instance manager containing a replica longhorn/longhorn#9874

Closed

DamiaSan approved these changes Dec 3, 2024

View reviewed changes

derekbit added 2 commits December 4, 2024 11:21

chore(vendor): update dependencies

f8a4890

Longhorn 9874 Signed-off-by: Derek Su <[email protected]>

feat: decrease transport_ack_timeout

2559c18

Decreasing transport_ack_timeout value for imporving the error detection of the transport layer. Longhorn 9874 Signed-off-by: Derek Su <[email protected]>

derekbit force-pushed the issue-9874 branch from e9de501 to 2559c18 Compare December 4, 2024 03:21

derekbit merged commit bbd88c0 into longhorn:main Dec 4, 2024
10 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: decrease transport_ack_timeout #251

feat: decrease transport_ack_timeout #251

derekbit commented Dec 1, 2024 •

edited

Loading

coderabbitai bot commented Dec 1, 2024 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

coderabbitai bot left a comment

codecov bot commented Dec 1, 2024 •

edited

Loading

derekbit commented Dec 2, 2024

DamiaSan commented Dec 2, 2024

derekbit commented Dec 2, 2024

DamiaSan commented Dec 2, 2024

derekbit commented Dec 2, 2024

feat: decrease transport_ack_timeout #251

feat: decrease transport_ack_timeout #251

Conversation

derekbit commented Dec 1, 2024 • edited Loading

Which issue(s) this PR fixes:

What this PR does / why we need it:

Special notes for your reviewer:

Additional documentation or context

coderabbitai bot commented Dec 1, 2024 • edited Loading

Walkthrough

Changes

Assessment against linked issues

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

coderabbitai bot left a comment

Choose a reason for hiding this comment

codecov bot commented Dec 1, 2024 • edited Loading

Codecov Report

derekbit commented Dec 2, 2024

DamiaSan commented Dec 2, 2024

derekbit commented Dec 2, 2024

DamiaSan commented Dec 2, 2024

derekbit commented Dec 2, 2024

derekbit commented Dec 1, 2024 •

edited

Loading

coderabbitai bot commented Dec 1, 2024 •

edited

Loading

codecov bot commented Dec 1, 2024 •

edited

Loading