ci: enable error detection

[derekbit]

Which issue(s) this PR fixes:

Issue longhorn/longhorn#7985

What this PR does / why we need it:

Special notes for your reviewer:

Additional documentation or context

[derekbit]

The error is due to #110

[innobead]

the PR check failed.

[derekbit]

The CI test always failed.

...

	/go/src/github.com/longhorn/longhorn-spdk-engine/vendor/github.com/longhorn/nsfilelock/nsfilelock.go:105 +0x82
created by github.com/longhorn/nsfilelock.(*NSFileLock).Lock in goroutine 5894
	/go/src/github.com/longhorn/longhorn-spdk-engine/vendor/github.com/longhorn/nsfilelock/nsfilelock.go:100 +0x845

goroutine 22401 [runnable]:
internal/poll.runtime_pollWait(0x7f80583e7878, 0x72)
	/usr/local/go/src/runtime/netpoll.go:343 +0x85
internal/poll.(*pollDesc).wait(0xc00c8338e0, 0xc00e5c1c00?, 0x1)
	/usr/local/go/src/internal/poll/fd_poll_runtime.go:84 +0xb1
internal/poll.(*pollDesc).waitRead(...)
	/usr/local/go/src/internal/poll/fd_poll_runtime.go:89
internal/poll.(*FD).Read(0xc00c8338c0, {0xc00e5c1c00, 0x200, 0x200})
	/usr/local/go/src/internal/poll/fd_unix.go:164 +0x3e5
os.(*File).read(...)
	/usr/local/go/src/os/file_posix.go:29
os.(*File).Read(0xc000f96608, {0xc00e5c1c00, 0x200, 0x200})
	/usr/local/go/src/os/file.go:118 +0xad
bytes.(*Buffer).ReadFrom(0xc00e164540, {0xfb4300, 0xc000f96608})
	/usr/local/go/src/bytes/buffer.go:211 +0x110
io.copyBuffer({0xfb4840, 0xc00e164540}, {0xfb4300, 0xc000f96608}, {0x0, 0x0, 0x0})
	/usr/local/go/src/io/io.go:416 +0x1bf
io.Copy(...)
	/usr/local/go/src/io/io.go:389
os/exec.(*Cmd).writerDescriptor.func1()
	/usr/local/go/src/os/exec/exec.go:560 +0x5b
os/exec.(*Cmd).Start.func2(0xc0022786c0)
	/usr/local/go/src/os/exec/exec.go:717 +0x3d
created by os/exec.(*Cmd).Start in goroutine 22400
	/usr/local/go/src/os/exec/exec.go:716 +0xf3a
FAIL	github.com/longhorn/longhorn-spdk-engine/pkg	300.459s

https://drone-pr.longhorn.io/longhorn/longhorn-spdk-engine/134/1/3

@shuo-wu Can you help check it? Should we enable CI test for now?

[FrankYang0529]

Not sure why the go vet error doesn't break the pipeline first 🤔

Running: go vet
# github.com/longhorn/longhorn-spdk-engine/pkg/spdk
pkg/spdk/replica.go:523:14: result of fmt.Errorf call not used

[derekbit]

Not sure why the go vet error doesn't break the pipeline first 🤔

Running: go vet
# github.com/longhorn/longhorn-spdk-engine/pkg/spdk
pkg/spdk/replica.go:523:14: result of fmt.Errorf call not used

Is it an error or warning?

[FrankYang0529]

Not sure why the go vet error doesn't break the pipeline first 🤔

Running: go vet
# github.com/longhorn/longhorn-spdk-engine/pkg/spdk
pkg/spdk/replica.go:523:14: result of fmt.Errorf call not used

Is it an error or warning?

I think it's error. We have to remove this line too.

longhorn-spdk-engine/scripts/validate

Line 7 in dfb90ba

set +e

[innobead]

LGTM, but waiting for resolving the failed PR check.

[mergify]

This pull request is now in conflict. Could you fix it @derekbit? 🙏

[mergify]

This pull request is now in conflict. Could you fix it @derekbit? 🙏

[derekbit]

We don't need this anymore. The CI error due to the spdk_tgt timeout is fixed in #158. Error detection is always enabled.

cc @innobead @FrankYang0529