fix: fix potential nil dereference error

Longhorn 9244 Signed-off-by: Derek Su <[email protected]>
longhorn · Nov 29, 2024 · 5cf64bb · 5cf64bb
1 parent 114edff
commit 5cf64bb
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/pkg/client/client.go b/pkg/client/client.go
@@ -229,7 +229,10 @@ func (c *SPDKClient) ReplicaRebuildingSrcStart(srcReplicaName, dstReplicaName, d
 		DstReplicaAddress:   dstReplicaAddress,
 		ExposedSnapshotName: exposedSnapshotName,
 	})
-	return resp.ExposedSnapshotLvolAddress, errors.Wrapf(err, "failed to start replica rebuilding src %s for rebuilding replica %s(%s)", srcReplicaName, dstReplicaName, dstReplicaAddress)
+	if err != nil {
+		return "", errors.Wrapf(err, "failed to start replica rebuilding src %s for rebuilding replica %s(%s)", srcReplicaName, dstReplicaName, dstReplicaAddress)
+	}
+	return resp.ExposedSnapshotLvolAddress, nil
 }
 
 // ReplicaRebuildingSrcFinish asks the source replica to stop exposing the parent snapshot of the head (if necessary) and clean up the dst replica related cache