fix(engine): no need to mark engine as error after failing to suspend…

… or resume engine No need to mark engine as error after failing to suspend or resume engine. Longhorn manager will retry the operation later. Longhorn 9104 Signed-off-by: Derek Su <[email protected]>
longhorn · Nov 29, 2024 · 5236c00 · 5236c00
1 parent 3a8b260
commit 5236c00
Showing 1 changed file with 2 additions and 4 deletions.
diff --git a/pkg/spdk/engine.go b/pkg/spdk/engine.go
@@ -2087,8 +2087,7 @@ func (e *Engine) Suspend(spdkClient *spdkclient.Client) (err error) {
 
 		if err != nil {
 			if e.State != types.InstanceStateError {
-				e.State = types.InstanceStateError
-				e.log.WithError(err).Info("Failed to suspend engine, will mark the engine as error")
+				e.log.WithError(err).Warn("Failed to suspend engine")
 			}
 			e.ErrorMsg = err.Error()
 		} else {
@@ -2119,8 +2118,7 @@ func (e *Engine) Resume(spdkClient *spdkclient.Client) (err error) {
 
 		if err != nil {
 			if e.State != types.InstanceStateError {
-				e.State = types.InstanceStateError
-				e.log.WithError(err).Info("Failed to resume engine, will mark the engine as error")
+				e.log.WithError(err).Warn("Failed to resume engine")
 			}
 			e.ErrorMsg = err.Error()
 		} else {