fix: prevent nil dereference when updating replica mode ERR

longhorn/longhorn-9852 Signed-off-by: Chin-Ya Huang <[email protected]>
longhorn · Dec 3, 2024 · 46dd200 · 46dd200
1 parent bfa1d21
commit 46dd200
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/pkg/spdk/engine.go b/pkg/spdk/engine.go
@@ -996,8 +996,10 @@ func (e *Engine) ReplicaAdd(spdkClient *spdkclient.Client, dstReplicaName, dstRe
 			}
 		}
 		if engineErr != nil || err != nil {
-			e.log.WithError(err).Errorf("Engine failed to start replica %s rebuilding, will mark the rebuilding replica mode from %v to ERR", dstReplicaName, e.ReplicaStatusMap[dstReplicaName].Mode)
-			e.ReplicaStatusMap[dstReplicaName].Mode = types.ModeERR
+			if e.ReplicaStatusMap[dstReplicaName] != nil && e.ReplicaStatusMap[dstReplicaName].Mode != types.ModeERR {
+				e.log.WithError(err).Errorf("Engine failed to start replica %s rebuilding, will mark the rebuilding replica mode from %v to ERR", dstReplicaName, e.ReplicaStatusMap[dstReplicaName].Mode)
+				e.ReplicaStatusMap[dstReplicaName].Mode = types.ModeERR
+			}
 			updateRequired = true
 		}
 	}()