Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(deps): update module github.com/longhorn/longhorn-engine to v1.7.2 (v1.7.x) #660

Open
wants to merge 1 commit into
base: v1.7.x
Choose a base branch
from
Open

fix(deps): update module github.com/longhorn/longhorn-engine to v1.7.2 (v1.7.x) #660

wants to merge 1 commit into from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Sep 7, 2024 •
edited
Loading

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
github.com/longhorn/longhorn-engine v1.7.1-rc2 -> v1.7.2 age adoption passing confidence

Release Notes

longhorn/longhorn-engine (github.com/longhorn/longhorn-engine)

v1.7.2

Compare Source

v1.7.1

Compare Source

v1.7.1-rc3

Compare Source

Configuration

📅 Schedule: Branch creation - "after 10am on saturday,on sunday" in timezone Asia/Taipei, Automerge - At any time (no schedule defined).

🚦 Automerge: Enabled.

♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate Renovate
Copy link
Contributor Author

renovate bot commented Sep 7, 2024 •
edited
Loading

ℹ Artifact update notice

File name: go.mod

In order to perform the update(s) described in the table above, Renovate ran the go get command, which resulted in the following additional change(s):

  • 19 additional dependencies were updated

Details:

Package Change
github.com/longhorn/backupstore v0.0.0-20240823072635-7afd6aa10d3e -> v0.0.0-20241013024428-b52180a5191f
github.com/longhorn/go-common-libs v0.0.0-20240821134112-907f57efd48f -> v0.0.0-20241012153249-4c71f1cbdd9e
github.com/longhorn/types v0.0.0-20240725040629-473d671316c4 -> v0.0.0-20241007141758-3640f2357238
golang.org/x/net v0.28.0 -> v0.30.0
google.golang.org/grpc v1.65.0 -> v1.67.1
google.golang.org/protobuf v1.34.2 -> v1.35.1
k8s.io/mount-utils v0.31.0 -> v0.31.1
github.com/Azure/azure-sdk-for-go/sdk/storage/azblob v1.4.0 -> v1.4.1
github.com/longhorn/go-iscsi-helper v0.0.0-20240811043302-df8de353dd58 -> v0.0.0-20241006012607-08f5166d1fad
github.com/longhorn/sparse-tools v0.0.0-20240729132735-18b207e459ff -> v0.0.0-20240907135423-37af3c64d59d
github.com/opencontainers/runc v1.1.13 -> v1.1.14
golang.org/x/oauth2 v0.21.0 -> v0.22.0
golang.org/x/sys v0.24.0 -> v0.26.0
golang.org/x/term v0.23.0 -> v0.25.0
golang.org/x/text v0.17.0 -> v0.19.0
google.golang.org/genproto/googleapis/rpc v0.0.0-20240528184218-531527333157 -> v0.0.0-20240814211410-ddb44dafa142
k8s.io/api v0.31.0 -> v0.31.1
k8s.io/apimachinery v0.31.0 -> v0.31.1
k8s.io/client-go v0.31.0 -> v0.31.1

@renovate renovate bot force-pushed the renovate/v1.7.x-longhorn-branch-repo-dependencies branch 2 times, most recently from 4391248 to 242a42e Compare September 18, 2024 23:49
@renovate renovate bot force-pushed the renovate/v1.7.x-longhorn-branch-repo-dependencies branch from 242a42e to 88e65bc Compare October 9, 2024 08:20
@derekbit
Copy link
Member

derekbit commented Oct 13, 2024 •
edited
Loading 

# github.com/longhorn/longhorn-spdk-engine/pkg/client
vendor/github.com/longhorn/longhorn-spdk-engine/pkg/client/client.go:868:19: client.EngineBackupRestoreFinish undefined (type spdkrpc.SPDKServiceClient has no field or method EngineBackupRestoreFinish)
vendor/github.com/longhorn/longhorn-spdk-engine/pkg/client/client.go:868:59: undefined: spdkrpc.EngineBackupRestoreFinishRequest
# github.com/longhorn/longhorn-instance-manager/pkg/client
pkg/client/proxy_backup.go:200:14: undefined: rpc.EngineBackupRestoreFinishRequest
pkg/client/proxy_backup.go:211:22: c.service.BackupRestoreFinish undefined (type imrpc.ProxyEngineServiceClient has no field or method BackupRestoreFinish)

We might not need to update longhorn-spdk-engine for v1.7.x.
cc @c3y1huang

@renovate renovate bot force-pushed the renovate/v1.7.x-longhorn-branch-repo-dependencies branch 2 times, most recently from 4bd5270 to 02bf72e Compare October 18, 2024 03:33
@renovate renovate bot changed the title fix(deps): update module github.com/longhorn/longhorn-engine to v1.7.1 (v1.7.x) fix(deps): update module github.com/longhorn/longhorn-engine to v1.7.2 (v1.7.x) Oct 18, 2024
@renovate renovate bot force-pushed the renovate/v1.7.x-longhorn-branch-repo-dependencies branch from 02bf72e to 02c8364 Compare October 28, 2024 06:41
@coderabbitai coderabbitai
Copy link

coderabbitai bot commented Oct 28, 2024

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@innobead
Copy link
Member

@derekbit can we let the code review bot ignore the PRs created by bots?

@derekbit
Copy link
Member

derekbit commented Oct 28, 2024 •
edited
Loading

@derekbit can we let the code review bot ignore the PRs created by bots?

No, we cannot do it. coderabbit should ignore the PR created by bot, so this is a bug of coderabbit. I will report back to coderabbit developers.

Wait, the PR is skipped by coderabbit.

#660 (comment)

@innobead
Copy link
Member

how smart it is. 🥇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@derekbit @innobead