Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add longhorn/types #1015

Merged
merged 2 commits into from
Apr 18, 2024
Merged

feat: add longhorn/types #1015

merged 2 commits into from
Apr 18, 2024

Conversation

FrankYang0529
Copy link
Contributor

Which issue(s) this PR fixes:

Issue longhorn/longhorn#6744

What this PR does / why we need it:

Special notes for your reviewer:

Additional documentation or context

@FrankYang0529 FrankYang0529 force-pushed the LH-6744 branch 2 times, most recently from 081ccbc to b318574 Compare February 20, 2024 06:11
Copy link

mergify bot commented Feb 20, 2024

This pull request is now in conflict. Could you fix it @FrankYang0529? 🙏

@FrankYang0529 FrankYang0529 changed the title feat: add longhorn-interface feat: add longhorn/types Feb 20, 2024
Copy link

mergify bot commented Feb 23, 2024

This pull request is now in conflict. Could you fix it @FrankYang0529? 🙏

@FrankYang0529 FrankYang0529 force-pushed the LH-6744 branch 15 times, most recently from b59b5b8 to 9aeb9ab Compare February 29, 2024 04:49
@FrankYang0529 FrankYang0529 marked this pull request as ready for review February 29, 2024 05:34
@FrankYang0529 FrankYang0529 requested a review from a team as a code owner February 29, 2024 05:34
@FrankYang0529 FrankYang0529 force-pushed the LH-6744 branch 2 times, most recently from 8d5ff45 to 803e962 Compare April 8, 2024 02:43
Copy link

mergify bot commented Apr 17, 2024

This pull request is now in conflict. Could you fix it @FrankYang0529? 🙏

Copy link

mergify bot commented Apr 17, 2024

This pull request is now in conflict. Could you fix it @FrankYang0529? 🙏

Signed-off-by: PoAn Yang <[email protected]>
Signed-off-by: PoAn Yang <[email protected]>
Copy link
Member

@derekbit derekbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekbit derekbit merged commit 5195981 into longhorn:master Apr 18, 2024
6 checks passed
@FrankYang0529 FrankYang0529 deleted the LH-6744 branch April 18, 2024 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants