-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(lvol): add lvol detach parent API #180
base: main
Are you sure you want to change the base?
Conversation
Longhorn 9922 Signed-off-by: Damiano Cipriani <[email protected]>
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #180 +/- ##
==========================================
- Coverage 22.88% 22.68% -0.21%
==========================================
Files 34 34
Lines 4842 4885 +43
==========================================
Hits 1108 1108
- Misses 3557 3600 +43
Partials 177 177
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Which issue(s) this PR fixes:
Issue longhorn/longhorn#9922
What this PR does / why we need it:
Added the new SPDK API
bdev_lvol_detach_parent
to detach a logical volume from its parent without changing lvol's data.Special notes for your reviewer:
This PR depends on the PR longhorn/spdk#40
Additional documentation or context