fix(deps): update Dockerfile to SPDK longhorn-v24.09 branch #165
Conversation
WalkthroughThe pull request modifies the Changes
Assessment against linked issues
Possibly related PRs
Suggested reviewers
Warning Rate limit exceeded@DamiaSan has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 23 minutes and 4 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (1)
🔇 Additional comments (3)Dockerfile.dapper (3)Line range hint The update is cleanly focused on the SPDK version change while maintaining the existing build structure and dependencies. The base image and build tools remain appropriate for the update. #!/bin/bash
# Description: Final verification of recent builds with the new SPDK version
# Check recent workflow runs to verify successful builds with the new version
echo "Checking recent CI builds..."
gh api repos/longhorn/go-spdk-helper/actions/runs --jq '.workflow_runs[] | select(.head_sha == "'${GITHUB_SHA}'") | {status: .status, conclusion: .conclusion, html_url: .html_url}'
The build process uses specific configurations for different architectures and Python 3.11. Let's ensure these remain compatible with the new SPDK version. #!/bin/bash
# Description: Check build configuration compatibility
# Check for any changes in Python version requirements or build configurations
echo "Checking for build configuration changes..."
gh api repos/longhorn/spdk/compare/a6478cde7e0cff2fb09992868308a7387aa5202a...10463b5c13b454e173707628b9eac608081f5082 --jq '.files[] | select(.filename | contains("configure") or .filename | contains("scripts/pkgdep/requirements.txt"))'
# Check if architecture-specific build flags are still valid
echo "Checking architecture-specific configurations..."
gh api repos/longhorn/spdk/contents/configure?ref=10463b5c13b454e173707628b9eac608081f5082 | jq -r '.content' | base64 -d | grep -A 5 "target-arch"Also applies to: 46-61
The SPDK commit ID has been updated while keeping other dependencies unchanged. Let's verify the alignment with the longhorn-v24.09 branch. ✅ Verification successful✓ SPDK commit verified and properly aligned with longhorn-v24.09 The SPDK commit ID
The commit is correctly positioned as the HEAD of the longhorn-v24.09 branch, making it suitable for this update. 🏁 Scripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash
# Description: Verify SPDK commit and branch alignment, and check dependency compatibility
# Check if the commit exists and is in the correct branch
echo "Checking SPDK commit and branch..."
gh api repos/longhorn/spdk/commits/10463b5c13b454e173707628b9eac608081f5082 --jq '.commit.message'
# Check if this commit is part of the longhorn-v24.09 branch
gh api repos/longhorn/spdk/branches/longhorn-v24.09 --jq '.commit.sha'
# Verify if there are any breaking changes in build dependencies between the old and new versions
echo "Checking for changes in build dependencies..."
gh api repos/longhorn/spdk/compare/a6478cde7e0cff2fb09992868308a7387aa5202a...10463b5c13b454e173707628b9eac608081f5082 --jq '.files[] | select(.filename | contains("scripts/pkgdep"))'
Length of output: 454 Script: #!/bin/bash
# Let's try a different approach to verify the SPDK commit and branch
# 1. First, let's check if the commit exists in the repository
echo "Checking if the commit exists..."
gh api repos/longhorn/spdk/git/commits/10463b5c13b454e173707628b9eac608081f5082 \
--jq '{message: .message, author: .author.name}'
# 2. Let's get the latest commit from longhorn-v24.09 branch
echo -e "\nChecking latest commit on longhorn-v24.09 branch..."
gh api repos/longhorn/spdk/branches/longhorn-v24.09 \
--jq '{sha: .commit.sha, message: .commit.commit.message}'
# 3. Let's check the commit history to see if our target commit is in the branch
echo -e "\nChecking commit history in the branch..."
gh api "repos/longhorn/spdk/commits?sha=longhorn-v24.09&per_page=50" \
--jq '.[] | select(.sha == "10463b5c13b454e173707628b9eac608081f5082") | {sha: .sha, message: .commit.message}'
Length of output: 1575 Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Longhorn 9700 Signed-off-by: Damiano Cipriani <[email protected]>
DamiaSan
force-pushed
the
longhorn-v24.09
branch
from
45f3303 to
972fd05
Compare
DamiaSan
changed the title
|
@DamiaSan Some checks failed
Please fix them before merging the PR. |
DamiaSan
changed the title
Done, now it want the prefix in PR's name too.
It doesn't depend by this commit, it seems that in one test the tgt is not ready when the assert is checked. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #165 +/- ##
=======================================
Coverage 22.89% 22.89%
=======================================
Files 34 34
Lines 4813 4813
=======================================
Hits 1102 1102
Misses 3537 3537
Partials 174 174
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Which issue(s) this PR fixes:
Issue longhorn/longhorn#9700
What this PR does / why we need it:
Special notes for your reviewer:
Additional documentation or context