Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add func BdevLvolGetWithFilter #151

Merged
merged 1 commit into from
Oct 17, 2024
Merged

Conversation

shuo-wu
Copy link
Collaborator

@shuo-wu shuo-wu commented Sep 27, 2024

Which issue(s) this PR fixes:

longhorn/longhorn#9121

What this PR does / why we need it:

Special notes for your reviewer:

Additional documentation or context

Copy link

codecov bot commented Sep 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 22.53%. Comparing base (22115a9) to head (0f57302).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #151      +/-   ##
==========================================
- Coverage   22.85%   22.53%   -0.32%     
==========================================
  Files          34       34              
  Lines        4757     3931     -826     
==========================================
- Hits         1087      886     -201     
+ Misses       3497     2872     -625     
  Partials      173      173              
Flag Coverage Δ
unittests 22.53% <100.00%> (-0.32%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

pkg/spdk/spdk_test.go Outdated Show resolved Hide resolved
Longhorn 9121

Signed-off-by: Shuo Wu <[email protected]>
Copy link
Member

@derekbit derekbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekbit derekbit merged commit c88e58c into longhorn:main Oct 17, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants