Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style(import): align alias naming with convention used in other repos #145

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

c3y1huang
Copy link
Contributor

@c3y1huang c3y1huang commented Aug 27, 2024

Which issue(s) this PR fixes:

Issue None

What this PR does / why we need it:

Remove camel casing in alias to align convention with other repos.

Special notes for your reviewer:

None

Additional documentation or context

None

@c3y1huang c3y1huang self-assigned this Aug 27, 2024
Copy link

codecov bot commented Aug 27, 2024

Codecov Report

Attention: Patch coverage is 60.46512% with 17 lines in your changes missing coverage. Please review.

Project coverage is 23.35%. Comparing base (aa44b59) to head (0fc64e3).
Report is 1 commits behind head on main.

Files Patch % Lines
pkg/spdk/setup/setup.go 0.00% 4 Missing ⚠️
app/cmd/dmsetup/dmsetup.go 0.00% 2 Missing ⚠️
app/cmd/nvmecli/nvmecli.go 0.00% 2 Missing ⚠️
app/cmd/spdksetup/spdksetup.go 0.00% 2 Missing ⚠️
pkg/nvme/nvme.go 66.66% 2 Missing ⚠️
pkg/nvme/nvmecli.go 81.81% 2 Missing ⚠️
app/cmd/spdktgt/spdktgt.go 0.00% 1 Missing ⚠️
pkg/util/device.go 75.00% 1 Missing ⚠️
pkg/util/dmsetup.go 85.71% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #145   +/-   ##
=======================================
  Coverage   23.35%   23.35%           
=======================================
  Files          34       34           
  Lines        4748     4748           
=======================================
  Hits         1109     1109           
  Misses       3465     3465           
  Partials      174      174           
Flag Coverage Δ
unittests 23.35% <60.46%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@c3y1huang c3y1huang marked this pull request as ready for review August 27, 2024 05:07
@c3y1huang c3y1huang requested review from derekbit and a team August 27, 2024 05:07
Copy link
Member

@derekbit derekbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekbit derekbit merged commit 9fe38ff into longhorn:main Aug 27, 2024
9 checks passed
@c3y1huang c3y1huang deleted the style-go-common-lib-imports branch August 28, 2024 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants