feat(nvmf): decrease reconnect-delay-sec to 2 seconds #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows to re-establish the connection more quickly and prevent long stuck. Longhorn 9190 Signed-off-by: Derek Su <[email protected]>
|
Any specific reason for decreasing this? |
|
5-second reconnect-delay-sec is too long before. I think we can decrease to a smaller value. If the connection recovers, the IO can continue soon. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #137 +/- ##
=======================================
Coverage 23.35% 23.35%
=======================================
Files 34 34
Lines 4748 4748
=======================================
Hits 1109 1109
Misses 3465 3465
Partials 174 174
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
shuo-wu
approved these changes
Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
Issue longhorn/longhorn#9190
What this PR does / why we need it:
Allows to re-establish the connection more quickly and prevent long stuck.
Special notes for your reviewer:
Additional documentation or context