Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restore: re-read block file while falling back to different decompression method #172

Merged
merged 1 commit into from
May 9, 2024

Conversation

derekbit
Copy link
Member

@derekbit derekbit commented May 3, 2024

io.ReadCloser can be casted to io.Seeker if need to fall back to other decompression method.

longhorn/longhorn#7687

Which issue(s) this PR fixes:

Issue #

What this PR does / why we need it:

Special notes for your reviewer:

Additional documentation or context

@derekbit derekbit self-assigned this May 3, 2024
@derekbit derekbit requested a review from ChanYiLin May 3, 2024 16:33
Copy link

codecov bot commented May 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 18.24%. Comparing base (3fa6a4a) to head (e459ca8).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #172      +/-   ##
==========================================
+ Coverage   17.55%   18.24%   +0.68%     
==========================================
  Files           3        3              
  Lines         450      433      -17     
==========================================
  Hits           79       79              
+ Misses        364      347      -17     
  Partials        7        7              
Flag Coverage Δ
unittests 18.24% <ø> (+0.68%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@derekbit
Copy link
Member Author

derekbit commented May 7, 2024

Hello @c3y1huang @ChanYiLin @mantissahz @innobead
Can you help review it if you have time? Thank you.

@derekbit
Copy link
Member Author

derekbit commented May 8, 2024

ping @shuo-wu @innobead

s3/s3_service.go Outdated Show resolved Hide resolved
@derekbit derekbit requested a review from shuo-wu May 9, 2024 04:29
@derekbit derekbit changed the title s3: Read() returns io.ReadCloser restore: re-read block file while falling back to different decompression method May 9, 2024
util.go Outdated Show resolved Hide resolved
@derekbit derekbit merged commit 0f25d29 into longhorn:master May 9, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants