Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fall back to other decompression method if the current one fails #167

Merged
merged 1 commit into from
Apr 17, 2024

Conversation

derekbit
Copy link
Member

Which issue(s) this PR fixes:

Issue longhorn/longhorn#7687

What this PR does / why we need it:

The mitigation will be removed after identifying longhorn/longhorn#7687

Special notes for your reviewer:

Additional documentation or context

@derekbit derekbit requested a review from innobead April 17, 2024 03:22
@derekbit derekbit self-assigned this Apr 17, 2024
ChanYiLin
ChanYiLin previously approved these changes Apr 17, 2024
Copy link
Contributor

@ChanYiLin ChanYiLin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@c3y1huang c3y1huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Drone failed, could you check?

deltablock.go Outdated Show resolved Hide resolved
Copy link
Member

@innobead innobead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, LGTM.

Please update the suggestion for backing image resotre abdn backup restore parts.

backupbackingimage/backupbackingimage.go Outdated Show resolved Hide resolved
backupbackingimage/backupbackingimage.go Outdated Show resolved Hide resolved
backupbackingimage/backupbackingimage.go Outdated Show resolved Hide resolved
util/util.go Show resolved Hide resolved
innobead
innobead previously approved these changes Apr 17, 2024
Copy link
Member

@innobead innobead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

deltablock.go Outdated Show resolved Hide resolved
util/util.go Outdated Show resolved Hide resolved
util/util.go Show resolved Hide resolved
The mitigation will be removed after identifying longhorn/longhorn#7687

Longhorn 7687

Signed-off-by: Derek Su <[email protected]>
@innobead innobead enabled auto-merge (rebase) April 17, 2024 07:12
@innobead innobead disabled auto-merge April 17, 2024 07:15
@innobead innobead merged commit 3bd377e into longhorn:master Apr 17, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants