Merge pull request #66 from logzio/shade-java-sender

shade java sender
logzio · Nov 13, 2019 · e61c88b · e61c88b
2 parents 80b23e8 + 098a584
commit e61c88b
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 10 deletions.
diff --git a/README.md b/README.md
@@ -8,15 +8,21 @@ This appender sends logs to your [Logz.io](http://logz.io) account, using non-bl
 This appender uses [LogzioSender](https://github.com/logzio/logzio-java-sender) implementation. All logs are backed up to a local file system before being sent. Once you send a log, it will be enqueued in the queue and 100% non-blocking. There is a background task that will handle the log shipment for you. This jar is an "Uber-Jar" that shades both BigQueue, Gson and Guava to avoid "dependency hell".
 
 ### Installation from maven
-```xml
+```
 <dependency>
     <groupId>io.logz.logback</groupId>
     <artifactId>logzio-logback-appender</artifactId>
     <version>1.0.23</version>
 </dependency>
+
+<dependency>
+    <groupId>ch.qos.logback</groupId>
+    <artifactId>logback-classic</artifactId>
+    <version>1.2.3</version>
+</dependency>
 ```
 
-### Logback Example Configuration
+### logback.xml Example Configuration
 ```xml
 <!-- Use debug=true here if you want to see output from the appender itself -->
 <!-- Use line=true here if you want to see the line of code that generated this log -->
@@ -142,6 +148,8 @@ Will send a log to Logz.io that looks like this:
 ```
 
 ### Release notes
+ - 1.0.24
+   - shade some dependencies
  - 1.0.22 - 1.0.23
    - update logzio-sender version
  - 1.0.21

diff --git a/pom.xml b/pom.xml
@@ -115,17 +115,15 @@
                 </executions>
                 <configuration>
                     <minimizeJar>true</minimizeJar>
-                    <artifactSet>
-                        <includes>
-                            <include>io.logz.sender:logzio-sender</include>
-                            <include>com.google.guava:guava</include>
-                        </includes>
-                    </artifactSet>
                     <createDependencyReducedPom>false</createDependencyReducedPom>
                     <relocations>
                         <relocation>
-                            <pattern>com.google.common</pattern>
-                            <shadedPattern>io.logz.logback.com.google.common</shadedPattern>
+                            <pattern>com.google</pattern>
+                            <shadedPattern>io.logz.logback.com.google</shadedPattern>
+                        </relocation>
+                        <relocation>
+                            <pattern>io.logz.sender</pattern>
+                            <shadedPattern>io.logz.logback-appender.sender</shadedPattern>
                         </relocation>
                     </relocations>
                     <filters>