Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug fix] Drain queue upon shutdown event #40

Merged
merged 2 commits into from
Sep 23, 2024
Merged

Conversation

8naama
Copy link
Contributor

@8naama 8naama commented Sep 23, 2024

Description

  • Add drain to the shipper queue upon shutdown, to ensure no data loss if the queue isn't empty at shutdown
  • Upgrade package version golang.org/x/[email protected] >> v0.25.0
  • Update readme

What type of PR is this?

(check all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build / CI
  • ⏩ Revert

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help from somebody

@8naama 8naama requested review from yotamloe and ralongit September 23, 2024 12:27
@8naama 8naama merged commit 7f55be0 into main Sep 23, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants