-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Documentation for ECS Setup with OpenTelemetry for Java, Python, and Node.js #704
Conversation
✅ Deploy Preview for deluxe-empanada-3ebf3b ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! 🎉
I noticed some comments that were not resolved from before:
All the sub-headers are still bolded. I think that for consistency we should avoid bolding headers.
And if we decide to add bold formatting, it should apply only to main headers and be addressed as a part of a larger PR (to align all the pages).
I also left a comment about a command that seems to have been accidentally changed and it shouldn't be modified
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left last comment with suggestion
Added comprehensive setup documentation for deploying ECS services with OpenTelemetry instrumentation for Java, Python, and Node.js applications.
Each language has dedicated instructions, including code, Dockerfiles, OpenTelemetry configuration, and ECS task definitions.
This documentation aids users in configuring distributed tracing with Logz.io as the telemetry endpoint.