Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Documentation for ECS Setup with OpenTelemetry for Java, Python, and Node.js #704

Merged
merged 9 commits into from
Nov 20, 2024

Conversation

bardabun
Copy link
Contributor

Added comprehensive setup documentation for deploying ECS services with OpenTelemetry instrumentation for Java, Python, and Node.js applications.
Each language has dedicated instructions, including code, Dockerfiles, OpenTelemetry configuration, and ECS task definitions.

This documentation aids users in configuring distributed tracing with Logz.io as the telemetry endpoint.

Copy link

netlify bot commented Nov 12, 2024

Deploy Preview for deluxe-empanada-3ebf3b ready!

Name Link
🔨 Latest commit 3add0d7
🔍 Latest deploy log https://app.netlify.com/sites/deluxe-empanada-3ebf3b/deploys/673dacbf00e9e8000910c0dc
😎 Deploy Preview https://deploy-preview-704--deluxe-empanada-3ebf3b.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

docs/shipping/Code/java.md Outdated Show resolved Hide resolved
docs/shipping/Code/java.md Outdated Show resolved Hide resolved
docs/shipping/Code/java.md Outdated Show resolved Hide resolved
docs/shipping/Code/node-js.md Outdated Show resolved Hide resolved
docs/shipping/Code/node-js.md Outdated Show resolved Hide resolved
docs/shipping/Code/node-js.md Outdated Show resolved Hide resolved
docs/shipping/Code/python.md Outdated Show resolved Hide resolved
docs/shipping/Code/node-js.md Outdated Show resolved Hide resolved
docs/shipping/Code/python.md Show resolved Hide resolved
docs/shipping/Code/python.md Outdated Show resolved Hide resolved
@bardabun bardabun requested a review from 8naama November 19, 2024 08:26
docs/shipping/Code/java.md Outdated Show resolved Hide resolved
docs/shipping/Code/java.md Outdated Show resolved Hide resolved
docs/shipping/Code/java.md Outdated Show resolved Hide resolved
docs/shipping/Code/java.md Show resolved Hide resolved
docs/shipping/Code/java.md Outdated Show resolved Hide resolved
docs/shipping/Code/java.md Outdated Show resolved Hide resolved
docs/shipping/Code/python.md Outdated Show resolved Hide resolved
docs/shipping/Code/python.md Outdated Show resolved Hide resolved
docs/shipping/Code/python.md Outdated Show resolved Hide resolved
docs/shipping/Code/python.md Outdated Show resolved Hide resolved
@bardabun bardabun requested a review from 8naama November 19, 2024 13:56
Copy link
Contributor

@8naama 8naama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 🎉

I noticed some comments that were not resolved from before:

All the sub-headers are still bolded. I think that for consistency we should avoid bolding headers.
And if we decide to add bold formatting, it should apply only to main headers and be addressed as a part of a larger PR (to align all the pages).

I also left a comment about a command that seems to have been accidentally changed and it shouldn't be modified

Copy link
Contributor

@8naama 8naama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left last comment with suggestion

docs/shipping/Code/java.md Outdated Show resolved Hide resolved
@bardabun bardabun merged commit 71f1910 into master Nov 20, 2024
8 of 10 checks passed
@bardabun bardabun deleted the docs/add-ecs-otel branch November 20, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants