Fix object timestamp logic #243
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should make the s3 input compatible with more S3 compatible backends since the timestamps are taken from the same call. It also changes the logic to something I thought makes more sense. It shouldn't really matter if a file has changed since listing, just if it has changed during downloading/processing. If it had just changed during listing but before the download, the exact same file would be processed twice.
|
💚 CLA has been signed |
|
Anyone got an idea on how to stub this properly? It's been a while writing Ruby :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should make the s3 input compatible with more S3 compatible backends since the timestamps are taken from the same call.
It also changes the logic to something I thought makes more sense.
It shouldn't really matter if a file has changed since listing, just if it has changed during downloading/processing.
If it had just changed during listing but before the download, the exact same file would be processed twice.