enable force-decoding with decode_gzip => force
#185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danhermann
approved these changes
Aug 2, 2019
lib/logstash/inputs/s3.rb
Outdated
| @gzip_detector = case @decode_gzip | ||
| when "force" then -> (_) { true } | ||
| when "detect" then -> (filename) { filename.end_with?('.gz','.gzip') } | ||
| else fail(LogStah::ConfigurationError, "unsupported value `#{@decode_gzip}` for decode_gzip") |
There was a problem hiding this comment.
Logstah::ConfigurationError is missing an 'S'. Otherwise, LGTM pending successful CI.
yaauie
force-pushed
the
force-gzip-decoding
branch
from
1689365 to
8ba80de
Compare
|
Hello @yaauie! I was hoping to check if there is a release plan for this change to be merged into master? And if there is a tentative date for it? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #181
Enables users to force gzip decoding on files that are not named with gzip-style extensions. I explicitly avoided using a
boolean-style variable as proposed in #181 because the default being false lead to false assumptions (e.g.,is_gzipped=>falsewould not disable gzip decompression).