Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark fully read zip file completed in sincedb #287

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

max-frank
Copy link

This PR fixes #286

Note that this PR is currently missing a unit test for this as I am not really sure how to write one as I am not a ruby developer.
I think checking the @path_in_sincedb value after a complete read should be work as a unit test.

@cla-checker-service
Copy link

❌ Author of the following commits did not sign a Contributor Agreement:
4f4913b

Please, read and sign the above mentioned agreement if you want to contribute to this project

@max-frank
Copy link
Author

Note on the CLA I signed it as of 3/26/2021 10:56:27 AM (timestamp according to the DocuSign document)

@max-frank
Copy link
Author

I am not to sure what is going on with this issue
image

The test seems to randomly fail. I believe this random failures are unrelated to the code changes of this PR. Note that this same random failures seem to occur for #289

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix fully read zipped files not being properly serialized in sincedb
2 participants