Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Standardize SSL settings #6

Merged
merged 2 commits into from
Sep 14, 2023
Merged

Standardize SSL settings #6

merged 2 commits into from
Sep 14, 2023

Conversation

edmocosta
Copy link
Contributor

Release notes

Deprecates the ssl option in favor of ssl_enabled

What does this PR do?

  • Deprecated the ssl option in favor of ssl_enabled
  • Bumped logstash-input-http gem to version >= 3.7.2 (SSL-normalized)
  • Updated logstash-input-http deprecated configs usages (ssl, ssl_verify_mode) to the new ones.

Why is it important/What is the impact to the user?

This PR makes the plugin SSL settings consistent with the naming convention defined in the elastic/logstash#14905.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files (and/or docker env variables)
  • I have added tests that prove my fix is effective or that my feature works

Related issues

@edmocosta edmocosta changed the title [WIP] Normalised SSL settings [WIP] Standardize SSL settings Sep 13, 2023
@edmocosta edmocosta force-pushed the standardize_ssl_settings branch from b13f1d2 to 08af86f Compare September 13, 2023 12:19
@edmocosta edmocosta changed the title [WIP] Standardize SSL settings Standardize SSL settings Sep 13, 2023
@edmocosta edmocosta marked this pull request as ready for review September 13, 2023 12:40
@edmocosta edmocosta self-assigned this Sep 13, 2023
roaksoax
roaksoax approved these changes Sep 14, 2023
View reviewed changes
Copy link

@roaksoax roaksoax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one minor thing inline, otherwise, LGTM!

docs/index.asciidoc Outdated Show resolved Hide resolved
@edmocosta @roaksoax
Update docs/index.asciidoc
b95c67a 
Co-authored-by: Andres Rodriguez <[email protected]>
@edmocosta edmocosta merged commit 4665d3f into logstash-plugins:main Sep 14, 2023
@edmocosta edmocosta deleted the standardize_ssl_settings branch September 14, 2023 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roaksoax roaksoax roaksoax approved these changes

Assignees

@edmocosta edmocosta

Labels
status:needs-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Logstash - Plugins - SSL Settings Standardization - Standardize Elastic Serverless Forwarder INPUT settings
2 participants
@edmocosta @roaksoax