Flush only when necessary #21
Conversation
| if self.save: | ||
| self.storage_handler.flush() |
There was a problem hiding this comment.
One qq, if we do not flush on the exit, when will it be flushed?
There was a problem hiding this comment.
It will never be flushed if self.save is set to False. (e.g. we don't need to save anything when logging Hessian)
There was a problem hiding this comment.
In such case, why don'y we just change the flush() function?
There was a problem hiding this comment.
Oh you mean flush being a no-op when self.save is False. That would also do!
There was a problem hiding this comment.
Yes! In that way, we don't have to write an if statement every time 'flush' is called, rather leave the code as it is and just make the flush to do dry run or perhaps just clear the memory!
There was a problem hiding this comment.
sg! I'll close this PR then.
#20