Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added type annotations #157

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Added type annotations #157

wants to merge 1 commit into from

Conversation

joachimmetz
Copy link
Member

@joachimmetz joachimmetz commented May 31, 2020 •
edited
Loading

Added type annotations

@joachimmetz joachimmetz added blocked Work cannot progress until another issue is resolved code health Non-functional changes to improve code health labels May 31, 2020
@joachimmetz joachimmetz marked this pull request as ready for review May 31, 2020 12:25
@joachimmetz joachimmetz force-pushed the typing branch 2 times, most recently from 138c1db to 2bd423b Compare May 31, 2020 14:00
@joachimmetz joachimmetz mentioned this pull request May 31, 2020
Open
3 tasks
@joachimmetz joachimmetz removed the blocked Work cannot progress until another issue is resolved label May 31, 2020
@joachimmetz joachimmetz requested a review from Onager May 31, 2020 14:39
@joachimmetz
Copy link
Member Author

Looks like we need to drop Python 3.5 support to fully utilize type annotations.

@joachimmetz joachimmetz force-pushed the typing branch 5 times, most recently from c562376 to d1645b6 Compare June 2, 2020 09:18
@joachimmetz joachimmetz added the blocked Work cannot progress until another issue is resolved label Jun 4, 2020
@joachimmetz joachimmetz changed the base branch from master to main February 8, 2021 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Onager Onager Awaiting requested review from Onager

Assignees

@Onager Onager

Labels
blocked Work cannot progress until another issue is resolved code health Non-functional changes to improve code health
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joachimmetz @Onager