Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Upgrade dependences and go version #66

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

cychiang
Copy link

Background

The vcluster has up-to-date version of some dependencies than vcluster-sdk. I think it's good to keep these two in the same position in terms of the go version and dependencies.

Summary

  • Replace deprecated implementations with recommended ways

    • genericclioptions is deprecated and replace by genericiooptions
    • cluster.NewClientFunc has been replaced by client.NewClientFunc
    • PollImmediateInfinite has been deprecated and recommended to use PollUntilContextCancel instead
    • MetricsBindAddress and Namespace has beed removed from manager.Options
    • WithInsecure is deprecated and replace by WithTransportCredentials
  • Bump up controller-runtime related libraries to the latest version as following:

k8s.io/api v0.26.1 -> v0.28.2
k8s.io/apiextensions-apiserver v0.26.1 -> v0.28.2
k8s.io/apimachinery v0.26.1 -> v0.28.2
k8s.io/cli-runtime v0.26.1 -> v0.28.2
k8s.io/client-go v0.26.1 -> v0.28.2
k8s.io/klog/v2 v2.90.0 -> v2.100.1
k8s.io/kube-aggregator v0.26.1 -> v0.28.2
k8s.io/kubectl v0.26.1 -> v0.28.2
sigs.k8s.io/controller-runtime v0.14.4 -> v0.16.2

Please help me to refine this PR and becomes ready to merge. 😄

@ctrox
Copy link

ctrox commented Jan 5, 2024

@cychiang I ran into your PR as I depend on vcluster-sdk and tried to upgrade controller-runtime to 1.16+. This PR is missing a few changes to make it compile: cychiang#1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants