Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

document new uninstall command #380

Closed
wants to merge 1 commit into from
Closed

Conversation

rohantmp
Copy link
Contributor

@rohantmp rohantmp commented Nov 29, 2024

resolves DOC-80
ENG-5243
in draft only since the feature it documents is not released yet. merge after v0.22 released

preview link: https://deploy-preview-380--vcluster-docs-site.netlify.app/docs/platform/how-to/uninstall

@rohantmp rohantmp marked this pull request as draft November 29, 2024 12:20
Copy link

netlify bot commented Nov 29, 2024

Deploy Preview for vcluster-docs-site ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 182d187
🔍 Latest deploy log https://app.netlify.com/sites/vcluster-docs-site/deploys/6749b6f6a54a3f000863a945
😎 Deploy Preview https://deploy-preview-380--vcluster-docs-site.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rohantmp
Copy link
Contributor Author

merge when vcluster v0.22 is released

@rohantmp rohantmp force-pushed the destroyCmd branch 3 times, most recently from 7134460 to 782c9c0 Compare November 29, 2024 12:41
@Piotr1215 Piotr1215 marked this pull request as ready for review December 13, 2024 14:36
Copy link
Contributor

@Piotr1215 Piotr1215 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be better to keep both uninstall methods (helm and CLI) in 2 separate tabs. Did the helm uninstall method change or only the CLI uninstall method is new?

@Piotr1215
Copy link
Contributor

Closing in favor of: #390

@Piotr1215 Piotr1215 closed this Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants