-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENG-4153 | Document setting up GKE Workload Identity/EKS Pod Identity #200
ENG-4153 | Document setting up GKE Workload Identity/EKS Pod Identity #200
Conversation
✅ Deploy Preview for vcluster-docs-site ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Thanks @janekbaraniewski this escaped my attention. I will take a look at it tomorrow |
@janekbaraniewski why did we drop the terraform module from the docs? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- We want to move this from the platform docs to the vCluster docs as most people will search for this in the vcluster docs. We also want to group both pages under Pod Identity and then have EKS and GKE.
- EKS: Integrations -> Identity -> EKS
- GKE: Integrations -> Identify -> GKE
- Since you need the platform, these pages should be labeled as pro, so it shows up in the side bar: Example front matter that you'll need: https://github.com/loft-sh/vcluster-docs/blob/main/vcluster/configure/vcluster-yaml/experimental/isolated-control-plane.mdx?plain=1#L5
- Since it will be under vCluster now instead of the platform, we should remove the vCluster Platform running as a pre-req and instead it becomes one of the steps of the guide. In that step, it should refer to the install vCluster Platform docs.
- Can the formats of the two guide match and follow the EKS style for the heading? So don't have headings that say Step 1 but instead 1.
- For the steps that are deploying the vcluster, can you either use the partial from the basics page as you can deploy vCluster however you want? https://github.com/loft-sh/vcluster-docs/blob/main/vcluster/deploy/basics.mdx?plain=1#L180
60dc669
to
7a0cc70
Compare
Can you run it through spell check real quick and maybe grammarly or a grammar check? I found a spelling error, but it might be easier to have you run it through spelling rather than me comment on each one. Also replace |
a443321
to
cf916ba
Compare
cf916ba
to
38b1d80
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: if we declare the env vars with all caps, can we reference them with all caps as well through out the docs?
Preview: https://deploy-preview-200--vcluster-docs-site.netlify.app/docs/platform/integrations/gke-workload-identity