Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start to add tests #52

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

AlecThomson
Copy link
Contributor

Adds simple tests as a base for more. Going under the pytest framework.

I've also added some dev tools which can be installed like:

pip install ".[dev]"

I'd recommend using this as the base for getting some CI/CD setup. I like GitHub actions, but there are a few options. It'd be good to start getting code coverage reports at the same time. I recently got a nice setup for this over in another repo, if you'd like an example. Check out the config here:
https://github.com/AlecThomson/FixMS/blob/main/.github/workflows/test.yml

@gmloose
Copy link
Collaborator

gmloose commented May 6, 2024

Looks good to me. For testing, you might want to consider using tox.
At ASTRON there's a CI/CD working group that tries to implement good practices w.r.t. to CI/CD. See https://git.astron.nl/templates for more details.

@AlecThomson
Copy link
Contributor Author

Happy for whatever set of CI/CD tools the maintainers would like to use. And my understanding is that Tox is completely compatible with Pytest tests as well. If its ok, I'd prefer to leave that config to the core maintainers, so that you can decide what platforms you'd like to support :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants