-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LUCI IF Update #12
Open
noahime
wants to merge
52
commits into
lofar-astron:master
Choose a base branch
from
adamparkosidis:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
LUCI IF Update #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Included 3C380 in dropdown menu in Calibrators
Added coordinates for 3C380 calibrator
update LUCI to calculate using SEFDs w.r.t. 60 MHz
Update text about effective rms calculations
update the HBA rms calculations and errors
update the requirements (dash-bootstrap-components has deprecated function in new versions)
update extra package necessary to make genpdf work
add function to find the maximum elevation of the input target
update calculator to take extra input for validating the input function
update the validate inputs for the target elevations (below the horizon and above 40 degrees elevation)
Update the backend to support the check for target elevations (especially if below the horizon and if target is below 40 degrees elevation)
Update backend to check and give warning for target elevations (below horizon and below 40 degrees elevation
Made the effective rms for HBA dependent on the theoretical noise, and added the overplot function that highlights the elevation figure for selected targets across the observation time
adjusted calculator to work with the newly added overplot function
removing strict error of target below 40 degrees elevation
added warning for unobservable source at -40 DEC or lower
changed obs_t to float(obt_t)
added alert to highlight low elevation sources
expand the sensitivity result table
change the warning for elevation to only show after the calculate button is pressed based on the different conditions.
update sensitivity table to have the theoretical noise be corrected with a geometrical corrected and add * notes for the warning message to elaborate
update some error
Update the warning text to explain the different sensitivity table columns
update warning message
update the elevation plot with: overplotting in the same colour as input targets, yaxis starts at 0, and no hover label for the overplot trace
update sensitivity table column names in genpdf to make them readable
update targetvis overplot to overplot w.r.t. highest elevation target
Exclude the calibrators and A-team sources if they are selected for overplotting
Updates the overplot function to exclude calibrators, A-team sources, and made it overplot on each input target, centered around its transit point
Expanded the README to display and include what was hosted on the LOFAR Imaging Cookbook
add LBA sparse to the read me observing modes
adjusted some text in the README to better reflect usage
changed the results tab to say results per target as the data size did not scale with the number of targets. Plus the warning message for low elevations was slightly adjusted to be more detailed
update fpdf module so that it won't crash anymore. Only fpdf2 works with python 3.7+
Change html formatting to allow fpdf2 to function
Change more html formatting for the tables
updated link to LUCI to ASTRON Gitlab instead of Github
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update for LUCI that rearranges the Results section with a sensitivity table exposing the theoretical and effective sensitivity as well as the mean elevation of each input target. Additionally, the visibility plot has an additional LST axis and several overplot functions highlighting some extra set-up parameters. The new calculated rms parameters are now dependent on mean source elevation, and for HBA the effective rms is based on LoTSS-DR2 data. LBA_SPARSE mode is added as antenna set and a new calibrator is added to the list.