Skip to content

Commit

Permalink
Merge branch 'gdsfactory:main' into main
Browse files Browse the repository at this point in the history
  • Loading branch information
lodoreds authored Jul 31, 2024
2 parents e06673e + 82277b1 commit 1b1c23f
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 23 deletions.
5 changes: 5 additions & 0 deletions .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -44,3 +44,8 @@ repos:
# rev: v1.1.333
# hooks:
# - id: pyright

- repo: https://github.com/rhysd/actionlint
rev: v1.7.1
hooks:
- id: actionlint
23 changes: 0 additions & 23 deletions docs/contribution.md
Original file line number Diff line number Diff line change
Expand Up @@ -31,26 +31,3 @@ The workflow is:
## Code of Conduct

This project is a community effort, and everyone is welcome to contribute. Everyone within the community is expected to abide by our [code of conduct](https://github.com/gdsfactory/gdsfactory/blob/main/docs/code_of_conduct.md)


## Changelog

We use `towncrier` for tracking changes and generating a changelog.
When making a pull request, we require that you add a towncrier entry along with the code changes.

```bash
towncrier create <PR number>.<change type>
```

Where change type can be `removed`, `deprecated`, `added`, `changed`, `fixed`

Running this will create a file in the `.changelog.d` directory with a filename.

Then before doing a new release we run


```bash
towncrier build --version=<version-number>
```

Where `<version-number>` is the expected version number of the release
3 changes: 3 additions & 0 deletions gdsfactory/components/text_freetype.py
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,9 @@ def text_freetype(
char = Component()
xoffset = 0
for letter in line:
if letter == " ":
xoffset += scale_factor * advance_x
continue
letter_dev = Component()
letter_template, advance_x, ascender = _get_glyph(font, letter)
scale_factor = size / ascender
Expand Down

0 comments on commit 1b1c23f

Please sign in to comment.