Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(website): Adjust break all to break word #3342

Merged
merged 4 commits into from
Dec 3, 2024
Merged

fix(website): Adjust break all to break word #3342

merged 4 commits into from
Dec 3, 2024

Conversation

theosanderson
Copy link
Member

@theosanderson theosanderson commented Dec 2, 2024

resolves #3341 and various other problems

preview URL: https://breakword.loculus.org/

Screenshot

image
becomes
image

We were using break-all which allows wrapping newlines very arbitrarily. Now we only use break-words
.

@theosanderson theosanderson added the preview Triggers a deployment to argocd label Dec 2, 2024
@theosanderson theosanderson changed the title Adjust break all to break word fix(website): Adjust break all to break word Dec 2, 2024
@theosanderson theosanderson added the format_me Triggers github_actions to format website code on PR label Dec 2, 2024
Copy link
Contributor

@anna-parker anna-parker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - noticed this fixes cases where we would split a line in the middle of a word

@theosanderson theosanderson merged commit 193436a into main Dec 3, 2024
19 checks passed
@theosanderson theosanderson deleted the breakword branch December 3, 2024 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
format_me Triggers github_actions to format website code on PR preview Triggers a deployment to argocd
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Formatting issues in "data use terms history" modal
2 participants