feat!: Drop the sample web-client temporarily
#368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
AiyionPrime
commented
Jul 24, 2024
AiyionPrime
commented
AiyionPrime
force-pushed
the
feat/temp-drop-web-client
branch
from
bfbcc1e
to
731b1d6
Compare
AiyionPrime
changed the title
web-client temporarily
1 task
AiyionPrime
force-pushed
the
feat/temp-drop-web-client
branch
3 times, most recently
from
1d5a1e1
to
e134b93
Compare
|
@locka99 Is merging this something you'd even consider? |
as it's currently not working for at least two different reasons: Commit(43afb6a): 'Implement JSON serialization on most built-in data types.', which broke the JS parsing and updating of subscribed values. And the other being Commit(eab4caa): 'Rewrite the client to be async all the way through', which indirectly halted subscriptions for servers implemented with this crate (locka99#324). Re-adding this sample would be highly appreciated. If possible with tests, which might prevent its recurring decay.
AiyionPrime
force-pushed
the
feat/temp-drop-web-client
branch
from
e134b93
to
4c7b416
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.