Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HK] Use MapPart in 'ActiveMapTracker' #478

Merged
merged 8 commits into from
Sep 17, 2021
Merged

[HK] Use MapPart in 'ActiveMapTracker' #478

merged 8 commits into from
Sep 17, 2021

Conversation

sschulz92
Copy link
Contributor

Signed-off-by: Sebastian Schulz [email protected]

sschulz92
sschulz92 commented Sep 17, 2021
View reviewed changes
Copy link
Contributor Author

@sschulz92 sschulz92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for helping me out, changes look good now 👍

@fgdrf
Copy link
Contributor

fgdrf commented Sep 17, 2021 •
edited
Loading

Tested uDig a bit (closing, opening Maps) and looks like the change doesn't break anything. However, disoverd two issues I just reported:

I slightly remember that the first one sounds very familiar... but has nothing to do with this change ;)

@fgdrf fgdrf merged commit 1f5332e into locationtech:master Sep 17, 2021
@fgdrf fgdrf added this to the 2.3.0 milestone Sep 17, 2021
@sschulz92 sschulz92 deleted the USE_MAPPART_IN_ActiveMapTracker branch December 20, 2021 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fgdrf fgdrf fgdrf requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@sschulz92 @fgdrf