Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-89: initial support for NTv2 #98

Merged
merged 4 commits into from
Mar 28, 2023

Conversation

barthanssens
Copy link
Contributor

Initial NTv2 parser (only one subgrid, little endian format), as suggested in #89

Signed-off-by:Bart Hanssens [email protected]

@pomadchin
Copy link
Member

pomadchin commented Mar 23, 2023

Wow, this is so nice! Could you add some test coverage as well?

@barthanssens
Copy link
Contributor Author

Sure, still tinkering with it (I guess I could add detection of endianness).

Currently it seems to work for a gsb file used in Belgium (https://www.ngi.be/website/wp-content/uploads/2020/07/NTv2-1.zip, CC-BY, about 5 MB size), but open to suggestions for smaller/other test files.

@pomadchin
Copy link
Member

pomadchin commented Mar 23, 2023

@barthanssens I was able to find europe/100800401.gsb 25.2 KB

Hopefully should work?

### Spain (Catalonia): ED50 -> ETRS89

*Source*: [Institut Cartogràfic i Geològic de Catalunya (ICGC)](http://www.icgc.cat/content/download/48766/337962/version/1/file/Malla_NTv2_11_03.zip)  
*Format*: NTv2  
*License*: [Creative Commons Attribution 4.0](http://creativecommons.org/licenses/by/4.0/)  
*Source CRS*: EPSG:4230 (ED50)  
*Target CRS*: EPSG:4258 (ETRS89)  
*Used by*: [EPSG:5661 Transformation](https://www.epsg-registry.org/export.htm?gml=urn:ogc:def:coordinateOperation:EPSG::5661)

* 100800401.gsb

Source

@barthanssens
Copy link
Contributor Author

Thanks @pomadchin , I'll give that one a try

Copy link
Member

@pomadchin pomadchin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Thank you and congratz with the first contribution!

@pomadchin pomadchin merged commit 96e395f into locationtech:master Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants