Refactor domain group resolver to use new group context. #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s localgov_microsites_group to be a minimum of 4.0.0-alpha3.
|
The tests are now passing on this @stephen-cox and @ekes Any chance one of you has a chance to review it? I don't think @markconroy is available at the moment. |
|
I think this is good to merge, and is the last part of the puzzle to get tests all passing on localgovdrupal/localgov_microsites_project#49 Unless anyone objects, I'm going to merge this, tag a release and look to tag a release of localgov_microsites_project |
markconroy
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This requires localgov_microsites_group to be a minimum of 4.0.0-alpha3.
@markconroy is this OK as a patch release do you think?