Allow module reinstall #392
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
localgovdrupal/localgov#762 (comment) How much does directories keep on working when you uninstall it, but keep all the config in place? Is it possible someone is wanting to do this? Do we want to support it? |
stephen-cox
requested changes
Sep 4, 2024
There was a problem hiding this comment.
For this to fully fix the issue described in #370 it also needs to add an enforced dependency to all the submodules in the modules directory.
|
Further to my comment above, you are not prevented from uninstalling Directories if directory content exists, leaving phantom content which throws errors if you try to access it. We'll need to address this first localgovdrupal/localgov#762 |
|
Interesting! I think we'll need to test this a bit more. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding enforced dependencies to config files to allow reinstallation - see here: #370