Merge pull request #74 from lo1tuma/parentheses-in-pr-titles

Support parentheses in PR titles
lo1tuma · Aug 25, 2016 · 64c9158 · 64c9158
2 parents ccf2482 + f51be5d
commit 64c9158
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 1 deletion.
diff --git a/lib/getMergedPullRequests.js b/lib/getMergedPullRequests.js
@@ -24,7 +24,7 @@ function getPullRequests(fromTag) {
                     return commit.indexOf('Merge pull request') === 0;
                 })
                 .map((pullRequest) => {
-                    const pattern = /^Merge pull request #(\d+) from (.*) \((.*)\)/;
+                    const pattern = /^Merge pull request #(\d+) from (.*?) \((.*)\)$/;
                     const matches = pullRequest.match(pattern);
 
                     return {

diff --git a/test/unit/lib/getMergedPullRequestsSpec.js b/test/unit/lib/getMergedPullRequestsSpec.js
@@ -105,4 +105,19 @@ describe('getMergedPullRequests', function () {
         return expect(getMergedPullRequests(anyRepo))
             .to.become(expectedResults);
     });
+
+    it('should work with parentheses in the commit message body', function () {
+        const gitLogMessages = [
+            'Merge pull request #42 from A (pr-42 message (fixes #21))'
+        ];
+
+        const expectedResults = [
+            { id: '42', title: 'pr-42 message (fixes #21)', label: 'bug' }
+        ];
+
+        gitLog.resolves(gitLogMessages.join('\n'));
+
+        return expect(getMergedPullRequests(anyRepo))
+            .to.become(expectedResults);
+    });
 });