UDriver parameter library #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is already the default value that's written to hardware when the record's VAL goes to 1.
This is a cleaner and more performant way of tracking parameter properties (such as write-only and type) than adding sets for each boolean property (which also means properties with more than one possibility weren't covered adequately). As a bonus, this improves the interface for defining these properties, which can be done directly with the parameter list passed to UDriver::UDriver().
These specific parameters only have 2 channels, not the 18 otherwise supported by this port's channel parameters. This was an unpredicted consequence of changes to uhal [1], which was missed because testing was mostly done with the FOFB IOC. [1] lnls-dig/uhal@c2265ff
And add the specific implementation of the function to the relevant modules.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on lnls-dig/uhal#40