-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor test functions with parametrization #554
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to merge.
@AlexanderFengler It's kind of strange that on my local computer the tests for Any ideas why? Maybe I didn't install things correctly? =============================================================================================== short test summary info ================================================================================================
FAILED tests/test_likelihoods.py::test_lapse_distribution_cav[0.0-analytical] - KeyError: 'rt,response'
FAILED tests/test_likelihoods.py::test_lapse_distribution_cav[0.0-approx_differentiable] - KeyError: 'rt,response'
FAILED tests/test_likelihoods.py::test_lapse_distribution_cav[0.0-blackbox] - KeyError: 'rt,response'
FAILED tests/test_likelihoods.py::test_lapse_distribution_cav[0.01-analytical] - KeyError: 'rt,response'
FAILED tests/test_likelihoods.py::test_lapse_distribution_cav[0.01-approx_differentiable] - KeyError: 'rt,response'
FAILED tests/test_likelihoods.py::test_lapse_distribution_cav[0.01-blackbox] - KeyError: 'rt,response'
FAILED tests/test_likelihoods.py::test_lapse_distribution_cav[0.05-analytical] - KeyError: 'rt,response'
FAILED tests/test_likelihoods.py::test_lapse_distribution_cav[0.05-approx_differentiable] - KeyError: 'rt,response'
FAILED tests/test_likelihoods.py::test_lapse_distribution_cav[0.05-blackbox] - KeyError: 'rt,response'
FAILED tests/test_likelihoods.py::test_lapse_distribution_cav[0.5-analytical] - KeyError: 'rt,response'
FAILED tests/test_likelihoods.py::test_lapse_distribution_cav[0.5-approx_differentiable] - KeyError: 'rt,response'
FAILED tests/test_likelihoods.py::test_lapse_distribution_cav[0.5-blackbox] - KeyError: 'rt,response'
====================================================================================== 12 failed, 7 passed, 14 warnings in 31.57s ====================================================================================== |
@cpaniaguam no idea actually. I will check on my end and report back. What's process did you follow for install? |
@cpaniaguam I think the branch was behind |
This pull request refactors the
test_likelihoods.py
file by adding extra parametrization. Thetest_no_inf_values_a
,test_no_inf_values_t
, andtest_no_inf_values_v
functions are combined into a singletest_no_inf_values
function. Thetest_bbox
function is also refactored to use parametrization.