Fix initval setters leading to NotImplementedError #547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexanderFengler
changed the title
digicosmos86
approved these changes
Aug 14, 2024
There was a problem hiding this comment.
Looks good! Just some minor comments.
BTW, looks like process_initvals in HSSM does not have docstrings. Can you fix that?
Line 251 in 906bce6
src/hssm/hssm.py
Outdated
Comment on lines
2079
to
2081
| if not isinstance(self._initvals, dict): | ||
| raise ValueError("self._initvals should not be a dictionary.") | ||
| else: |
There was a problem hiding this comment.
self._initvals can only be of type dict right? It's initialized as a dict
There was a problem hiding this comment.
most of these are just in response to mypy bugging me endlessly :D
will try to do a round of improvements. @digicosmos86
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the logic on how we store
initvals.We now attach and update a class property
.initvalsthat holds a dictionary.This dictionary is passed as
initvalsargument to the.sampler()method.All pre-processing of initial values now targets this dictionary, instead of attempting changes to the
pymc_modeldirectly.