parse span path as array (#333)

[dinmukhamedm]

Important

Change span path handling from string to array in SpanAttributes and update related functions for compatibility.

• Behavior:
  • Change span path handling from String to Vec<String> in SpanAttributes.
  • Update flat_path() to join path array into a string.
  • Modify extend_span_path() to append to path array.
• Functions:
  • Update from_db_span() in CHSpan to use flat_path().
  • Update inner_process_queue_spans() to use flat_path().
  • Modify create_datapoint() to handle path as array.
• Misc:
  • Remove unused import serde_json::Value in index.rs.

^{This description was created by for 587138c. It will automatically update as commits are pushed.}

[ellipsis-dev]

❌ Changes requested. Reviewed everything up to 587138c in 1 minute and 24 seconds

More details

• Looked at 136 lines of code in 4 files
• Skipped 0 files when reviewing.
• Skipped posting 3 drafted comments based on config settings.

1. app-server/src/traces/consumer.rs:247

• Draft comment:
  Using unwrap_or_default() can lead to unexpected behavior if the default value is not appropriate. Consider handling the None case explicitly to ensure the correct default behavior.
• Reason this comment was not posted:
  Comment was on unchanged code.

2. app-server/src/ch/spans.rs:94

• Draft comment:
  Consider defining a constant for the default string "<null>" to avoid repetition and potential errors. This pattern is used multiple times in the codebase.
• Reason this comment was not posted:
  Confidence changes required: 50%
  The unwrap_or with a default string "<null>" is used multiple times. It might be better to define a constant for this default value to avoid repetition and potential errors.

3. app-server/src/ch/spans.rs:93

• Draft comment:
  Consider defining a constant for the default string "<null>" to avoid repetition and potential errors. This pattern is used multiple times in the codebase.
• Reason this comment was not posted:
  Confidence changes required: 50%
  The unwrap_or with a default string "<null>" is used multiple times. It might be better to define a constant for this default value to avoid repetition and potential errors.

Workflow ID: wflow_BeULwbLGDq89qiSu

---

Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

[ellipsis-dev]

Using v.to_string() on a serde_json::Value may not produce the expected string representation. Consider using as_str() or handling different types explicitly.