Skip to content

Commit

Permalink
t5523: use test_i18ngrep for negation
Browse files Browse the repository at this point in the history
Replace the first form with the second one:

	! grep expected actual
	test_i18ngrep ! expected actual

The latter syntax is supported by test_i18ngrep defined in
t/test-lib.sh.

Although the test already passes whether GETTEXT_POSION is enabled, use
the i18n grep variant for the sake of consistency and also to make
obvious that those strings are subject to i18n.

Signed-off-by: Vasco Almeida <[email protected]>
Signed-off-by: Junio C Hamano <[email protected]>
  • Loading branch information
vascool authored and gitster committed Jun 17, 2016
1 parent de5ea4c commit a1347dc
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions t/t5523-push-upstream.sh
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ test_expect_success 'progress messages do not go to non-tty' '
# skip progress messages, since stderr is non-tty
git push -u upstream master >out 2>err &&
! grep "Writing objects" err
test_i18ngrep ! "Writing objects" err
'

test_expect_success 'progress messages go to non-tty (forced)' '
Expand All @@ -98,15 +98,15 @@ test_expect_success TTY 'push -q suppresses progress' '
ensure_fresh_upstream &&
test_terminal git push -u -q upstream master >out 2>err &&
! grep "Writing objects" err
test_i18ngrep ! "Writing objects" err
'

test_expect_success TTY 'push --no-progress suppresses progress' '
ensure_fresh_upstream &&
test_terminal git push -u --no-progress upstream master >out 2>err &&
! grep "Unpacking objects" err &&
! grep "Writing objects" err
test_i18ngrep ! "Unpacking objects" err &&
test_i18ngrep ! "Writing objects" err
'

test_expect_success TTY 'quiet push' '
Expand Down

0 comments on commit a1347dc

Please sign in to comment.