[AIG] Add LowerVariadic and LowerWordToBits passes #7739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uenoku
force-pushed
the
dev/hidetou/add-lower-variadic-and-words
branch
from
89dce89
to
4e61009
Compare
uenoku
commented
Oct 26, 2024
Comment on lines
+52
to
+64
| // Reuse bits if we can extract from `comb.concat` operands. | ||
| if (auto concat = operand.getDefiningOp<comb::ConcatOp>()) { | ||
| // For the simplicity, we only handle the case where all the | ||
| // `comb.concat` operands are single-bit. | ||
| if (concat.getNumOperands() == width && | ||
| llvm::all_of(concat.getOperandTypes(), [](Type type) { | ||
| return type.getIntOrFloatBitWidth() == 1; | ||
| })) { | ||
| // Be careful with the endianness here. | ||
| operands.push_back(concat.getOperand(width - i - 1)); | ||
| continue; | ||
| } | ||
| } |
There was a problem hiding this comment.
@maerhart I addressed the comment #7717 (comment) here. Thank you for the suggestion!
This commit adds AIG LowerVariadic pass to lower variadic AndInverter op to have at most two operands. This makes IR closer to traditinal AIG representation combined with LowerWordToBits pass
This commit ads LowerWordToBits pass that perform bit-blasting for AndInverterOp.
uenoku
force-pushed
the
dev/hidetou/add-lower-variadic-and-words
branch
from
4e61009
to
29cf976
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds two basic legalization pass that lowers multibit variadic AndInverter to a single bit binary AndInverter. Once after these lowerings were applied it's trivial to interact with traditional AIG representation.
This PR is extracted from #7717