Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix alphas cumprod #475

Merged
merged 1 commit into from
Mar 4, 2024
Merged

Fix alphas cumprod #475

merged 1 commit into from
Mar 4, 2024

Conversation

continue-revolution
Copy link
Collaborator

Without this PR, I cannot reproduce any result from auto upstream.

The reason is that ComfyUI init alphas cumprod at model loading time instead of sample time (auto does this) so we need another step.

Another change is that ComfyUI always does "quantize" when it convert sigma to t, but A1111 never does "quantize" from my observation.

Comparison:

A1111 v1.8.0 Forge before this change Forge after this change
00007-564673848 00000-564673848 00001-564673848

@continue-revolution
Copy link
Collaborator Author

@strawberrymelonpanda
Copy link

Certainly a lot closer and would be a welcomed fix, I haven't had any luck with AnimateDiff in Forge compared to A1111.

It's interesting there's still some minute differences between the two examples - The most noticeable is in Forge her left hand (viewer's right) disappears earlier.

I believe there's some very small differences in the skirt wrinkles and perhaps the way the shadows 'fill in' on the top as the arm lowers as well.

@continue-revolution
Copy link
Collaborator Author

@strawberrymelonpanda this is because forge’s clip text encoder (which encodes your prompt into a tensor) also gives slightly different result compared to A1111. I am not sure about the reason. Most likely another comfy issue. I also observe slight difference when I do single image generation.

@continue-revolution continue-revolution merged commit 72139b0 into main Mar 4, 2024
6 checks passed
@continue-revolution continue-revolution deleted the conrevo/fix-alphas-cumprod branch March 4, 2024 02:09
@MUTED64
Copy link

MUTED64 commented Mar 4, 2024

Error "Expected all tensors to be on the same device, but found at least two devices, cuda:0 and cpu" occurred after this PR merged. Here is the traceback.

lllyasviel added a commit that referenced this pull request Mar 4, 2024
@lllyasviel
Copy link
Owner

this has some conflicts to memory management and i2i and will be reviewed by me later

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants