-
Notifications
You must be signed in to change notification settings - Fork 797
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
controlnet extension - few compat fixes #474
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think the changes here are well justified.
- For
to_processing_unit
, can you share the code which callto_processing_unit
?- As no code in this repo actually calls
to_processing_unit
, I think you can implement it in your code, instead of adding the logic here.
- As no code in this repo actually calls
- For
None
filter, can you provide the code path thatNone
could be passed as ControlNet's script args?
@huchenlei this commit: light-and-ray/sd-webui-replacer@27b965c
|
I'm looking the code, and I think I've misunderstood and forge doesn't require replace dicts in p.script_args, and it was the same error about NoneType. So the part with to_processing_unit can be removed if you want. But I think it's better to keep it for backward compatibility. But None should be fixed in any way I think, because the webui works with them |
Btw I still need to check is unit enabled, and maybe other fields in future, and I need to have this function. I can write my analog in my code, but why when it's better to have universal conversion function inside external_code module Before this I had faced only with different lib path and mask which doesn't require special handling. It doesn't a big deal for extension like mine which just uses cn script and nothing else. But why external_code module shouldn't has the same interface with webui by your opinion, when this module was designed like a lib for usage by external extensions? 😐
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
waiting for @lllyasviel's review
hi we are going to close PRs before forge's recent major revision |
In support forge in my extension I've faced external_code no longer has
to_processing_unit
. And also it produces errors if few units are NoneChecklist: