-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transparent image infotext + saving support #6
Conversation
0044007
to
c0f2c85
Compare
Works! 😊👍 It would be helpful if the checkbox were ticked by default. It took me some time to realize I needed to search for it in the settings. Since the transparent image variant is the one primarily used, I don't see value in saving only the checkerboard version anyway. Enabling the transparent image option by default seems like a sensible choice to me. What do you think? |
WebP currently has the alpha channel stripped. That would need to be fixed upstream. |
basename="", | ||
seed=p.seeds[i], | ||
prompt=p.prompts[i], | ||
extension=getattr(opts, 'samples_format', 'png'), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
then here should ignore samples_format and fix to png I supposed?
since webp has bug and jpeg has no transparent, so only png?
Can confirm this commit works to fix the saving issue where the transparent png isn't also saved in the output folder. With this one, both are saved in the output dir, even if it's an external dir. |
An option to not save the "checkerboard" preview would be appreciated. This is useless content to output except for a preview purpose, I don't think it should be saved at all personally, but if someone has a use for it, an option would be alright. |
I haven't done any testing to verify but my guess is the checkerboard background is the one returned by default for compatibility reasons. Most webui code and extensions will strip out the alpha channel if one is found. The transparent image being passed into Waiting to make any changes to this PR until lllyasviel has a chance to review it. |
During batch generation when the '*-transparent.png' copy is saved, it has the incorrect seed in the info text. |
como la puedo usar? |
Thanks for this work ! ヾ(◍°∇°◍)ノ゙ |
Closing in favor of #99 which more fully encompasses these issues. |
Title. Transparent images are currently passed to the UI as a uint8 array where Gradio handles it. This properly adds infotext to the image and also adds the option for a user to save these images (in addition to the checkered-patterned image currently saved).