Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kINT: Fix synchronization problem #294

Merged
merged 1 commit into from
Oct 25, 2023
Merged

kINT: Fix synchronization problem #294

merged 1 commit into from
Oct 25, 2023

Conversation

Adam-pi3
Copy link
Collaborator

The reported problem with integrity verification on ARM64 (#269) is a result of a very tight race condition with tracepoints. Changes which simplify synchronization with JUMP_LABEL engine: f98da1b
affected differently ARM64 platform which made such race possible. However, potentially the same race problem may exist on x86 and this commit fixes it and should address #269

How Has This Been Tested?

I've run various stress manual tests on:

  • ARM64: using Raspberry Pi 4 (under the kernel 6.5.0-1005-raspi)
  • x86: using various kernels from Ubuntu 23.10 and 22.04.3, custom kernel 6.3.4 and CentOS 8 (kernel 4.18.0-240.15.1.el8_3.x86_64)

The reported problem with integrity verification on ARM64 (lkrg-org#269)
is a result of a very tight race condition with tracepoints.
Changes which simplify synchronization with JUMP_LABEL engine:
f98da1b
affected differently ARM64 platform which made such race possible.
However, potentially the same race problem may exist on x86 and
this commit fixes it and should address lkrg-org#269
Copy link
Contributor

@solardiz solardiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was a bit concerned this could introduce dead-locks, but grepping the kernel tree for uses of tracepoints_mutex this looks safe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants